Skip to content

Fix the bug that MissileSpawn=true causes the spawnee launcher to crash immediately when attacking#2289

Merged
Coronia merged 8 commits into
Phobos-developers:developfrom
DeathFishAtEase:MissileSpawnFix
Jul 18, 2026
Merged

Fix the bug that MissileSpawn=true causes the spawnee launcher to crash immediately when attacking#2289
Coronia merged 8 commits into
Phobos-developers:developfrom
DeathFishAtEase:MissileSpawnFix

Conversation

@DeathFishAtEase

@DeathFishAtEase DeathFishAtEase commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

This bug was introduced by the two hooks that modified SpawnTimer in #622.

[CARRIER_MS]:[CARRIER]
MissileSpawn=true
[CARRIER_SDF]:[CARRIER]
Spawner.DelayFrames=10000
[CARRIER_SDF_MS]:[CARRIER_MS]
Spawner.DelayFrames=10000

[Units]
3=Americans House,CARRIER,256,34,35,64,Guard,None,0,-1,0,-1,0,0
4=Americans House,CARRIER_MS,256,34,34,64,Guard,None,0,-1,0,-1,0,0
5=Americans House,CARRIER_SDF,256,34,33,64,Guard,None,0,-1,0,-1,0,0
6=Americans House,CARRIER_SDF_MS,256,34,32,64,Guard,None,0,-1,0,-1,0,0
pic-0 pic-1

This PR - normal operation / Nightly Build(c4490e8) - Fatal Error: Hey guys!

@DeathFishAtEase DeathFishAtEase self-assigned this Jul 16, 2026
@DeathFishAtEase DeathFishAtEase added ❓Phobos bug Something isn't working properly Tested ⚙️T1 T1 maintainer review is sufficient Bugfix This is a bugfix that does not need documentation beyond mention in changelog labels Jul 16, 2026
@phoboscn-bot

phoboscn-bot commented Jul 16, 2026

Copy link
Copy Markdown

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户：
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息：

https://www.phoboscn.top/t/topic/660/1

@github-actions

github-actions Bot commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Coronia
Coronia merged commit 4cfade0 into Phobos-developers:develop Jul 18, 2026
7 checks passed
@DeathFishAtEase
DeathFishAtEase deleted the MissileSpawnFix branch July 18, 2026 12:19
DeathFishAtEase added a commit to DeathFishAtEase/Phobos that referenced this pull request Jul 19, 2026
@DeathFishAtEase
[cn] update
acd22cc 
Phobos-developers#2289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NetsuNegi NetsuNegi NetsuNegi approved these changes

Assignees

@DeathFishAtEase DeathFishAtEase

Labels

Bugfix This is a bugfix that does not need documentation beyond mention in changelog ❓Phobos bug Something isn't working properly ⚙️T1 T1 maintainer review is sufficient Tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DeathFishAtEase @phoboscn-bot @NetsuNegi @Coronia